Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/modules/services/logging: Remove top-level with lib; #325936

Closed
wants to merge 17 commits into from

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 9, 2024

Description of changes

This removes all usage of with lib; under nixos/modules/services/logging. This is similar in scope to #306640, and is related to removing with lib; since it's an antipattern. See #208242 for more information on that.
I've run all applicable NixOS tests, and there are no behavioral changes, so there should be no incompatibilities.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 9, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 9, 2024
@pyrox0 pyrox0 force-pushed the logging-modules-remove-with-lib branch from 8cbd40f to e6d6062 Compare July 11, 2024 20:04
@pyrox0 pyrox0 changed the title nixos/modules/services/logging: Remove with lib; nixos/modules/services/logging: Remove top-level with lib; Jul 17, 2024
@pyrox0 pyrox0 force-pushed the logging-modules-remove-with-lib branch from e6d6062 to cad46cc Compare July 17, 2024 21:27
@pyrox0 pyrox0 force-pushed the logging-modules-remove-with-lib branch from cad46cc to 5b0ba17 Compare July 29, 2024 05:21
@pyrox0 pyrox0 force-pushed the logging-modules-remove-with-lib branch from 5b0ba17 to 63b78b5 Compare August 2, 2024 19:38
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/164

@pyrox0
Copy link
Member Author

pyrox0 commented Aug 28, 2024

Still looking for a review on this. It's been ready to merge for a month with no objections as far as I can see.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@pyrox0 pyrox0 closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants